staging: comedi: usbduxsigma: remove unnecessary check in usbdux_ao_cmd()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 23 May 2013 19:54:06 +0000 (12:54 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2013 11:40:55 +0000 (20:40 +0900)
The comedi core verifies that the command chanlist_len is valid for
the subdevice based on the len_chanlist that was setup during the
attach. There is no need to recheck it in the (*cmd) function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/usbduxsigma.c

index dab1a3cf3fcdca1850d276dfe007d4a6a18e379b..e9dfbb3e7de3b1954e8beb9c9943c032029ec324 100644 (file)
@@ -1189,12 +1189,6 @@ static int usbdux_ao_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
        for (i = 0; i < cmd->chanlist_len; ++i) {
                chan = CR_CHAN(cmd->chanlist[i]);
                gain = CR_RANGE(cmd->chanlist[i]);
-               if (i >= NUMOUTCHANNELS) {
-                       dev_err(&this_usbduxsub->interface->dev,
-                               "comedi%d: %s: channel list too long\n",
-                               dev->minor, __func__);
-                       break;
-               }
                this_usbduxsub->dac_commands[i] = chan;
                dev_dbg(&this_usbduxsub->interface->dev,
                        "comedi%d: dac command for ch %d is %x\n",