OMAP: hwmod: Enable module wakeup if in smartidle
authorRajendra Nayak <rnayak@ti.com>
Tue, 21 Sep 2010 14:28:30 +0000 (19:58 +0530)
committerPaul Walmsley <paul@pwsan.com>
Tue, 21 Sep 2010 21:28:30 +0000 (15:28 -0600)
If a module's OCP slave port is programmed to be in smartidle,
its also necessary that they have module level wakeup enabled.
Update _sysc_enable in hwmod framework to do this.

The thread "[PATCH 7/8] : Hwmod api changes" archived here:

http://www.mail-archive.com/linux-omap@vger.kernel.org/msg34212.html

has additional technical information on the rationale of this patch.

Sergei Shtylyov <sshtylyov@mvista.com> identified an indentation
problem with this patch - thanks, Sergei.

Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Signed-off-by: Partha Basak <p-basak2@ti.com>
Signed-off-by: BenoƮt Cousson <b-cousson@ti.com>
[paul@pwsan.com: revised patch description]
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>
arch/arm/mach-omap2/omap_hwmod.c

index f320cfb911d55ead6f43521eb68a6b2ca5d23ca0..d694067e6e9a4a6db8cb68a9ad4bb09bed1e36c7 100644 (file)
@@ -691,8 +691,6 @@ static void _sysc_enable(struct omap_hwmod *oh)
                _set_module_autoidle(oh, idlemode, &v);
        }
 
-       /* XXX OCP ENAWAKEUP bit? */
-
        /*
         * XXX The clock framework should handle this, by
         * calling into this code.  But this must wait until the
@@ -703,6 +701,10 @@ static void _sysc_enable(struct omap_hwmod *oh)
                _set_clockactivity(oh, oh->class->sysc->clockact, &v);
 
        _write_sysconfig(v, oh);
+
+       /* If slave is in SMARTIDLE, also enable wakeup */
+       if ((sf & SYSC_HAS_SIDLEMODE) && !(oh->flags & HWMOD_SWSUP_SIDLE))
+               _enable_wakeup(oh);
 }
 
 /**