mwifiex: fix coding style issue in mwifiex_deauthenticate
authorBing Zhao <bzhao@marvell.com>
Wed, 2 May 2012 02:53:51 +0000 (19:53 -0700)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 15 May 2012 21:27:27 +0000 (17:27 -0400)
Documentation/CodingStyle says
"Do not unnecessarily use braces where a single statement will do."

Use "switch/case", instead of "if/else_if/else", so that more cases
can be added later.

Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: Avinash Patil <patila@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/mwifiex/join.c

index 8a390982463ecd909c0262a0fc2c380109ed5066..aeb0b3fc4599c8bbd67c17f749a500f7e5980959 100644 (file)
@@ -1377,19 +1377,21 @@ static int mwifiex_deauthenticate_infra(struct mwifiex_private *priv, u8 *mac)
  */
 int mwifiex_deauthenticate(struct mwifiex_private *priv, u8 *mac)
 {
-       int ret = 0;
+       if (!priv->media_connected)
+               return 0;
 
-       if (priv->media_connected) {
-               if (priv->bss_mode == NL80211_IFTYPE_STATION) {
-                       ret = mwifiex_deauthenticate_infra(priv, mac);
-               } else if (priv->bss_mode == NL80211_IFTYPE_ADHOC) {
-                       ret = mwifiex_send_cmd_sync(priv,
-                                               HostCmd_CMD_802_11_AD_HOC_STOP,
-                                               HostCmd_ACT_GEN_SET, 0, NULL);
-               }
+       switch (priv->bss_mode) {
+       case NL80211_IFTYPE_STATION:
+               return mwifiex_deauthenticate_infra(priv, mac);
+       case NL80211_IFTYPE_ADHOC:
+               return mwifiex_send_cmd_sync(priv,
+                                            HostCmd_CMD_802_11_AD_HOC_STOP,
+                                            HostCmd_ACT_GEN_SET, 0, NULL);
+       default:
+               break;
        }
 
-       return ret;
+       return 0;
 }
 EXPORT_SYMBOL_GPL(mwifiex_deauthenticate);