staging: sm750fb: remove assignment from if condition
authorAnatoly Stepanov <drivengroove@gmail.com>
Sun, 28 Jun 2015 23:44:02 +0000 (02:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Jul 2015 01:29:41 +0000 (18:29 -0700)
Remove assignment from if condition according to checkpatch.pl message:
"ERROR: do not use assignment in if condition"

Signed-off-by: Anatoly Stepanov <drivengroove@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm750fb/sm750_hw.c

index 3093c2540bda3638a3407a76c2e30567194789d1..987da9e2aa2f2cb721a2d9d63b4deb883d70f158 100644 (file)
@@ -43,8 +43,8 @@ int hw_sm750_map(struct lynx_share *share, struct pci_dev *pdev)
         * in lynxfb_remove, or memory will not be mapped again
         * successfully
         * */
-
-       if ((ret = pci_request_region(pdev, 1, "sm750fb"))) {
+       ret = pci_request_region(pdev, 1, "sm750fb");
+       if (ret) {
                pr_err("Can not request PCI regions.\n");
                goto exit;
        }
@@ -77,7 +77,8 @@ int hw_sm750_map(struct lynx_share *share, struct pci_dev *pdev)
 
        /* reserve the vidmem space of smi adaptor */
 #if 0
-       if ((ret = pci_request_region(pdev, 0, _moduleName_))) {
+       ret = pci_request_region(pdev, 0, _moduleName_);
+       if (ret) {
                pr_err("Can not request PCI regions.\n");
                goto exit;
        }