change an if to an assert, fix comment.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@92364 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Transforms/Scalar/Reassociate.cpp b/lib/Transforms/Scalar/Reassociate.cpp
index ce14c85fe2392928cd185774ee1f6a65eaa9d34c..a75d027c50940eb2487e074933f6be42291f0e47 100644 (file)
--- a/lib/Transforms/Scalar/Reassociate.cpp
+++ b/lib/Transforms/Scalar/Reassociate.cpp
@@ -700,17 +700,17 @@ Value *Reassociate::OptimizeAdd(Instruction *I, std::vector<ValueEntry> &Ops) {
     // Now that we have inserted V and its sole use, optimize it. This allows
     // us to handle cases that require multiple factoring steps, such as this:
     // A*A*B + A*A*C   -->   A*(A*B+A*C)   -->   A*(A*(B+C))
-    if (NumAddedValues > 1)
-      ReassociateExpression(cast<BinaryOperator>(V));
+    assert(NumAddedValues > 1 && "Each occurrence should contribute a value");
+    ReassociateExpression(cast<BinaryOperator>(V));
     
     // If every add operand included the factor (e.g. "A*B + A*C"), then the
     // entire result expression is just the multiply "A*(B+C)".
     if (Ops.empty())
       return V2;
     
-    // Otherwise, we had some input that didn't have the fact, such as
+    // Otherwise, we had some input that didn't have the factor, such as
     // "A*B + A*C + D" -> "A*(B+C) + D".  Add the new multiply to the list of
-    // things being added.
+    // things being added by this operation.
     Ops.insert(Ops.begin(), ValueEntry(getRank(V2), V2));
   }