f2fs: fix to put root inode in error path of fill_super
authorChao Yu <chao2.yu@samsung.com>
Fri, 25 Jul 2014 04:55:09 +0000 (12:55 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 25 Jul 2014 15:19:57 +0000 (08:19 -0700)
We should put root inode correctly in error path of fill_super, otherwise we
may encounter a leak case of inode resource.

Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Reviewed-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/super.c

index 870fe199bafb44b8f482310815e7580a58608267..34649aa66e0428d28cd5ddd0f1864d228edc4537 100644 (file)
@@ -1033,8 +1033,9 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
                goto free_node_inode;
        }
        if (!S_ISDIR(root->i_mode) || !root->i_blocks || !root->i_size) {
+               iput(root);
                err = -EINVAL;
-               goto free_root_inode;
+               goto free_node_inode;
        }
 
        sb->s_root = d_make_root(root); /* allocate root dentry */