mmc: mxs-mmc: remove unneeded NULL check
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 16 Dec 2014 23:57:50 +0000 (02:57 +0300)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 19 Jan 2015 08:56:10 +0000 (09:56 +0100)
Static checkers complain about the inconsistent NULL checking here:

drivers/mmc/host/mxs-mmc.c:680 mxs_mmc_probe()
warn: variable dereferenced before check 'ssp->dmach' (see line 660)

The variable can't actually be NULL so we can remove the check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mxs-mmc.c

index 60c4ca97a727785bb5dcfbd292a023d04cd3b5d0..a82411a2c024e2182dde2201fc7dc59f927e1c2c 100644 (file)
@@ -677,8 +677,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
        return 0;
 
 out_free_dma:
-       if (ssp->dmach)
-               dma_release_channel(ssp->dmach);
+       dma_release_channel(ssp->dmach);
 out_clk_disable:
        clk_disable_unprepare(ssp->clk);
 out_mmc_free: