tipc: Eliminate unnecessary locking when starting topology service
authorAllan Stephens <Allan.Stephens@windriver.com>
Tue, 18 Jan 2011 18:58:27 +0000 (13:58 -0500)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 23 Feb 2011 23:05:13 +0000 (18:05 -0500)
Modifies the initialization code for TIPC's topology service to
avoid taking the spinlock protecting the subscriber list, since
there is no need to do this.

Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
net/tipc/subscr.c

index 98ee50b332aec201c3977699343d45bc86824665..138737242739bb25a60b00e5956da4c16e1aa2f4 100644 (file)
@@ -542,7 +542,6 @@ int tipc_subscr_start(void)
        spin_lock_init(&topsrv.lock);
        INIT_LIST_HEAD(&topsrv.subscriber_list);
 
-       spin_lock_bh(&topsrv.lock);
        res = tipc_createport(NULL,
                              TIPC_CRITICAL_IMPORTANCE,
                              NULL,
@@ -563,12 +562,10 @@ int tipc_subscr_start(void)
                goto failed;
        }
 
-       spin_unlock_bh(&topsrv.lock);
        return 0;
 
 failed:
        err("Failed to create subscription service\n");
-       spin_unlock_bh(&topsrv.lock);
        return res;
 }