nodestack: get_read_from_promise() never returns NULL

If the read_from_promise_idx is out of bounds, this is an error. We
should not return NULL (and in fact, our caller never expects us to
return NULL).

diff --git a/nodestack.cc b/nodestack.cc
index 00cc30f8d7efb22cf9e5b110d4628ac83db55e0f..515a2d313abbee54abbd132057100c89f9f711fc 100644 (file)
--- a/nodestack.cc
+++ b/nodestack.cc
@@ -458,8 +458,7 @@ void Node::add_read_from_promise(const ModelAction *reader)
  */
 Promise * Node::get_read_from_promise() const
 {
-       if (read_from_promise_idx < 0 || read_from_promise_idx >= ((int)read_from_promises.size()))
-               return NULL;
+       ASSERT(read_from_promise_idx >= 0 && read_from_promise_idx < ((int)read_from_promises.size()));
        return read_from_promises[read_from_promise_idx]->get_reads_from_promise();
 }