change printStringChar to emit characters as unsigned char instead of char,
authorChris Lattner <sabre@nondot.org>
Wed, 8 Apr 2009 00:28:38 +0000 (00:28 +0000)
committerChris Lattner <sabre@nondot.org>
Wed, 8 Apr 2009 00:28:38 +0000 (00:28 +0000)
avoiding sign extension for the top octet.  For "negative" chars, we'd print
stuff like:

.asciz "\702...
now we print:
.asciz "\302...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@68577 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/AsmPrinter/AsmPrinter.cpp

index 48085d59a26dd02ac844fce4317ecbacd020cb05..8fc1b8b01955bcd40c9470afa22befd766bc1736 100644 (file)
@@ -699,7 +699,7 @@ static inline char toOctal(int X) {
 
 /// printStringChar - Print a char, escaped if necessary.
 ///
-static void printStringChar(raw_ostream &O, char C) {
+static void printStringChar(raw_ostream &O, unsigned char C) {
   if (C == '"') {
     O << "\\\"";
   } else if (C == '\\') {
@@ -733,10 +733,8 @@ void AsmPrinter::EmitString(const std::string &String) const {
   else
     O << TAI->getAsciiDirective();
   O << '\"';
-  for (unsigned i = 0, N = String.size(); i < N; ++i) {
-    unsigned char C = String[i];
-    printStringChar(O, C);
-  }
+  for (unsigned i = 0, N = String.size(); i < N; ++i)
+    printStringChar(O, String[i]);
   if (AscizDirective)
     O << '\"';
   else
@@ -747,10 +745,8 @@ void AsmPrinter::EmitString(const std::string &String) const {
 /// EmitFile - Emit a .file directive.
 void AsmPrinter::EmitFile(unsigned Number, const std::string &Name) const {
   O << "\t.file\t" << Number << " \"";
-  for (unsigned i = 0, N = Name.size(); i < N; ++i) {
-    unsigned char C = Name[i];
-    printStringChar(O, C);
-  }
+  for (unsigned i = 0, N = Name.size(); i < N; ++i)
+    printStringChar(O, Name[i]);
   O << '\"';
 }