x86: boot - fix sparse warnings
authorHannes Eder <hannes@hanneseder.net>
Sun, 23 Nov 2008 18:37:09 +0000 (19:37 +0100)
committerIngo Molnar <mingo@elte.hu>
Sun, 23 Nov 2008 18:58:58 +0000 (19:58 +0100)
Impact: make global variables static

Fix these sparse warnings:

 arch/x86/boot/video.c:233:3: warning: symbol 'saved' was not declared. Should it be static?
 arch/x86/boot/video-vga.c:37:13: warning: symbol 'video_vga' was not declared. Should it be static?

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/boot/video-vga.c
arch/x86/boot/video.c

index b939cb476decf7d4d3089f6210c4fe3ecfb5f5be..5d4742ed4aa21dd83d968798a1c7ff92447907a1 100644 (file)
@@ -34,7 +34,7 @@ static struct mode_info cga_modes[] = {
        { VIDEO_80x25,  80, 25, 0 },
 };
 
-__videocard video_vga;
+static __videocard video_vga;
 
 /* Set basic 80x25 mode */
 static u8 vga_set_basic_mode(void)
@@ -259,7 +259,7 @@ static int vga_probe(void)
        return mode_count[adapter];
 }
 
-__videocard video_vga = {
+static __videocard video_vga = {
        .card_name      = "VGA",
        .probe          = vga_probe,
        .set_mode       = vga_set_mode,
index 83598b23093aa31398db2d1c9a5f89eb30733357..3bef2c1febe936bd01f1b8d7d6b7d1eb5b1f9bb6 100644 (file)
@@ -226,7 +226,7 @@ static unsigned int mode_menu(void)
 
 #ifdef CONFIG_VIDEO_RETAIN
 /* Save screen content to the heap */
-struct saved_screen {
+static struct saved_screen {
        int x, y;
        int curx, cury;
        u16 *data;