Staging: rtl8712: Use ether_addr_equal() over memcmp()
authorPunit Vara <punitvara@gmail.com>
Wed, 14 Oct 2015 18:25:53 +0000 (23:55 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Oct 2015 05:15:57 +0000 (22:15 -0700)
This patch is to the rtl871x_ioctl_linux.c file that fixes up following
warning reported by checkpatch.pl :

-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()

bssid and pnetwork->network.MacAddress both are 6 byte
array which aligned with u16

Signed-off-by: Punit Vara <punitvara@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl871x_ioctl_linux.c

index 5618dba8e05f93d7afe0eb8335d19a885a8c8cd1..e5a52a90feebf6985e9c1e98a004c28e9935b8ee 100644 (file)
@@ -1981,7 +1981,7 @@ static int r871x_get_ap_info(struct net_device *dev,
                        return -EINVAL;
                }
                netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
-               if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
+               if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
                        /* BSSID match, then check if supporting wpa/wpa2 */
                        pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
                               &wpa_ielen, pnetwork->network.IELength-12);