Move COFF Type in to the MCSymbolCOFF class.

The flags field in MCSymbol only needs to be 16-bits on ELF and MachO.
This moves the 16-bit Type out of there so that it can be reduced in size in a future commit.

Reviewed by Rafael Espíndola.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@239313 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/MC/MCSymbolCOFF.h b/include/llvm/MC/MCSymbolCOFF.h
index c7636e371dc649308c7e647669c3f39e8cda8660..efa23de18175954d7bba240ed2a7d9c173e95439 100644 (file)
--- a/include/llvm/MC/MCSymbolCOFF.h
+++ b/include/llvm/MC/MCSymbolCOFF.h
@@ -15,15 +15,18 @@
 namespace llvm {
 class MCSymbolCOFF : public MCSymbol {
 
+  /// This corresponds to the e_type field of the COFF symbol.
+  mutable uint16_t Type;
+
 public:
   MCSymbolCOFF(const StringMapEntry<bool> *Name, bool isTemporary)
-      : MCSymbol(SymbolKindCOFF, Name, isTemporary) {}
+      : MCSymbol(SymbolKindCOFF, Name, isTemporary), Type(0) {}
 
   uint16_t getType() const {
-    return (getFlags() & COFF::SF_TypeMask) >> COFF::SF_TypeShift;
+    return Type;
   }
-  void setType(uint16_t Type) const {
-    modifyFlags(Type << COFF::SF_TypeShift, COFF::SF_TypeMask);
+  void setType(uint16_t Ty) const {
+    Type = Ty;
   }
 
   static bool classof(const MCSymbol *S) { return S->isCOFF(); }

diff --git a/include/llvm/Support/COFF.h b/include/llvm/Support/COFF.h
index c48370e53d10a1e3e8b6200f17be836d868444c2..fa210272f7e76ce1d41a3db48a7ad9c276f134cf 100644 (file)
--- a/include/llvm/Support/COFF.h
+++ b/include/llvm/Support/COFF.h
@@ -155,15 +155,12 @@ namespace COFF {
     uint8_t  NumberOfAuxSymbols;
   };
 
-  enum SymbolFlags {
-    SF_TypeMask = 0x0000FFFF,
-    SF_TypeShift = 0,
+  enum SymbolFlags : uint16_t {
+    SF_ClassMask = 0x00FF,
+    SF_ClassShift = 0,
 
-    SF_ClassMask = 0x00FF0000,
-    SF_ClassShift = 16,
-
-    SF_WeakExternal = 0x01000000,
-    SF_SafeSEH = 0x02000000,
+    SF_WeakExternal = 0x0100,
+    SF_SafeSEH = 0x0200,
   };
 
   enum SymbolSectionNumber : int32_t {