drm/vmwgfx: Deletion of an unnecessary check before the function call "vfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 19 Nov 2014 16:50:19 +0000 (17:50 +0100)
committerDave Airlie <airlied@redhat.com>
Fri, 21 Nov 2014 02:16:40 +0000 (12:16 +1000)
The vfree() function performes also input parameter validation. Thus the test
around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

index 25f3c250fd98635ff50a7249f40e691686519674..db7621828bc7724205e2481ee4c031f7700f0422 100644 (file)
@@ -889,8 +889,7 @@ static int vmw_driver_unload(struct drm_device *dev)
 
        if (dev_priv->ctx.res_ht_initialized)
                drm_ht_remove(&dev_priv->ctx.res_ht);
-       if (dev_priv->ctx.cmd_bounce)
-               vfree(dev_priv->ctx.cmd_bounce);
+       vfree(dev_priv->ctx.cmd_bounce);
        if (dev_priv->enable_fb) {
                vmw_fb_close(dev_priv);
                vmw_kms_restore_vga(dev_priv);