ahci: fix PORTS_IMPL override
authorTejun Heo <htejun@gmail.com>
Tue, 19 Jun 2007 09:52:56 +0000 (18:52 +0900)
committerJeff Garzik <jeff@garzik.org>
Wed, 20 Jun 2007 23:56:21 +0000 (19:56 -0400)
If PORTS_IMPL register is zero, ahci initialize it to full mask
corresponding to nr_ports in the CAP register.  hpriv->cap, which is
initialized at the end of the function, is incorrectly used as value
of CAP causing ahci to always override PORTS_IMPL to 0x1 if it's zero.
Fix it.

This fixes a bug where early ich6 ahci can only access the first port.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/ahci.c

index 545f330e59a54bd5c6aebfca56a798d8cdd8a431..ca5229d24d8ed8f0692b64afed88d8e14cfbac33 100644 (file)
@@ -527,7 +527,7 @@ static void ahci_save_initial_config(struct pci_dev *pdev,
 
        /* fixup zero port_map */
        if (!port_map) {
-               port_map = (1 << ahci_nr_ports(hpriv->cap)) - 1;
+               port_map = (1 << ahci_nr_ports(cap)) - 1;
                dev_printk(KERN_WARNING, &pdev->dev,
                           "PORTS_IMPL is zero, forcing 0x%x\n", port_map);