OMAP: mailbox: send message in process context
authorKanigeri, Hari <h-kanigeri2@ti.com>
Mon, 29 Nov 2010 20:24:13 +0000 (20:24 +0000)
committerHari Kanigeri <h-kanigeri2@ti.com>
Thu, 2 Dec 2010 11:43:16 +0000 (05:43 -0600)
Schedule the Tasklet to send only when mailbox fifo is full and there are
pending messages in kfifo, else send the message directly in the Process
context. This would avoid needless scheduling of Tasklet for every message
transfer

Signed-off-by: Hari Kanigeri <h-kanigeri2@ti.com>
Acked-by: Hiroshi Doyu <hiroshi.doyu@nokia.com>
arch/arm/plat-omap/mailbox.c

index d9aa87c0a9213d0912ecce09282034b83af961ed..cc58b44325f2e4285f22e45a800384abea72d368 100644 (file)
@@ -92,20 +92,25 @@ int omap_mbox_msg_send(struct omap_mbox *mbox, mbox_msg_t msg)
        struct omap_mbox_queue *mq = mbox->txq;
        int ret = 0, len;
 
-       spin_lock(&mq->lock);
+       spin_lock_bh(&mq->lock);
 
        if (kfifo_avail(&mq->fifo) < sizeof(msg)) {
                ret = -ENOMEM;
                goto out;
        }
 
+       if (kfifo_is_empty(&mq->fifo) && !__mbox_poll_for_space(mbox)) {
+               mbox_fifo_write(mbox, msg);
+               goto out;
+       }
+
        len = kfifo_in(&mq->fifo, (unsigned char *)&msg, sizeof(msg));
        WARN_ON(len != sizeof(msg));
 
        tasklet_schedule(&mbox->txq->tasklet);
 
 out:
-       spin_unlock(&mq->lock);
+       spin_unlock_bh(&mq->lock);
        return ret;
 }
 EXPORT_SYMBOL(omap_mbox_msg_send);