Bluetooth: Hack: Don't dereference null pointer.
authorNick Pelly <npelly@google.com>
Thu, 8 Apr 2010 23:23:32 +0000 (16:23 -0700)
committerColin Cross <ccross@android.com>
Thu, 30 Sep 2010 00:49:31 +0000 (17:49 -0700)
This avoids the S305 panic during incoming connection.

S305 sends PSM 25 L2CAP connection request before the L2CAP info response.
When we receive that info response we crash on null pointer here.

Bug: 2127637
Change-Id: Ib637516251f46fa9a9c87ac015dc2f27df5a27fd
Signed-off-by: Nick Pelly <npelly@google.com>
net/bluetooth/l2cap.c

index 0ac962b978e153bf6d9b8ac63ac5f6f88958d991..72337ad07eca550357214e208baac0160c5c859a 100644 (file)
@@ -570,7 +570,8 @@ static void l2cap_conn_start(struct l2cap_conn *conn)
                                        struct sock *parent = bt_sk(sk)->parent;
                                        rsp.result = cpu_to_le16(L2CAP_CR_PEND);
                                        rsp.status = cpu_to_le16(L2CAP_CS_AUTHOR_PEND);
-                                       parent->sk_data_ready(parent, 0);
+                                       if (parent)
+                                               parent->sk_data_ready(parent, 0);
 
                                } else {
                                        sk->sk_state = BT_CONFIG;