[SCSI] fcoe: libfcoe: extra semicolon in CHECK_LOGGING macros causes compile error
authorJoe Eykholt <jeykholt@cisco.com>
Tue, 25 Aug 2009 20:58:42 +0000 (13:58 -0700)
committerJames Bottomley <James.Bottomley@suse.de>
Sat, 5 Sep 2009 14:47:34 +0000 (09:47 -0500)
If using code like this:
if (foo)
FCOE_DBG("foo\n);
else
FCOE_DBG("bar\n");

one gets compile errors because FCOE_DBG expands with its own semicolon,
making one too many for the if-statement.

Remove the offending semicolon in fcoe.h and also a similar case
in libfcoe.c.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/fcoe/fcoe.h
drivers/scsi/fcoe/libfcoe.c

index 68b9f855073bd5fa85de1179fddea891a173e475..65120e21f5c474f1722ba47e1b0aa287e09cfde6 100644 (file)
@@ -53,7 +53,7 @@ do {                                                                  \
                do {                                                    \
                        CMD;                                            \
                } while (0);                                            \
-} while (0);
+} while (0)
 
 #define FCOE_DBG(fmt, args...)                                         \
        FCOE_CHECK_LOGGING(FCOE_LOGGING,                                \
index 4db719d6ada14e1ddfe527de2a24be99f45443e8..d0b5208e1a45b43d5c41f20fa83ec99c858732f7 100644 (file)
@@ -69,7 +69,7 @@ do {                                                                  \
                do {                                                    \
                        CMD;                                            \
                } while (0);                                            \
-} while (0);
+} while (0)
 
 #define LIBFCOE_DBG(fmt, args...)                                      \
        LIBFCOE_CHECK_LOGGING(LIBFCOE_LOGGING,                          \