staging:iio:buffer trivial use of strtobool to remove dodgy equivalent.
authorJonathan Cameron <jic23@kernel.org>
Sat, 21 Apr 2012 09:09:32 +0000 (10:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Apr 2012 18:23:36 +0000 (11:23 -0700)
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/iio/industrialio-buffer.c

index 386ba760f3f1b648578e140bc9361693cd7eea50..59b0caf5deab73eba77ec7f91afe50d0f70ae741 100644 (file)
@@ -124,13 +124,15 @@ static ssize_t iio_scan_el_store(struct device *dev,
                                 const char *buf,
                                 size_t len)
 {
-       int ret = 0;
+       int ret;
        bool state;
        struct iio_dev *indio_dev = dev_get_drvdata(dev);
        struct iio_buffer *buffer = indio_dev->buffer;
        struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
 
-       state = !(buf[0] == '0');
+       ret = strtobool(buf, &state);
+       if (ret < 0)
+               return ret;
        mutex_lock(&indio_dev->mlock);
        if (iio_buffer_enabled(indio_dev)) {
                ret = -EBUSY;
@@ -169,11 +171,14 @@ static ssize_t iio_scan_el_ts_store(struct device *dev,
                                    const char *buf,
                                    size_t len)
 {
-       int ret = 0;
+       int ret;
        struct iio_dev *indio_dev = dev_get_drvdata(dev);
        bool state;
 
-       state = !(buf[0] == '0');
+       ret = strtobool(buf, &state);
+       if (ret < 0)
+               return ret;
+
        mutex_lock(&indio_dev->mlock);
        if (iio_buffer_enabled(indio_dev)) {
                ret = -EBUSY;