iwlwifi: Deinline iwl_{read,write}(8,32}
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sun, 23 Aug 2015 10:29:36 +0000 (13:29 +0300)
committerLuciano Coelho <luciano.coelho@intel.com>
Fri, 28 Aug 2015 10:26:33 +0000 (13:26 +0300)
With CONFIG_IWLWIFI_DEVICE_TRACING=y, these functions are rather large,
too big for inlining.

With this .config: http://busybox.net/~vda/kernel_config,
after uninlining these functions have sizes and callsite counts
as follows:

iwl_read32  475 bytes, 51 callsites
iwl_write32 477 bytes, 90 callsites
iwl_write8  493 bytes, 3 callsites

Reduction in size is about 74,000 bytes:

    text     data      bss       dec     hex filename
90758147 17226024 36659200 144643371 89f152b vmlinux0
90687995 17221928 36659200 144569123 89df323 vmlinux.after

Reported-by: Denys Vlasenko <dvlasenk@redhat.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
drivers/net/wireless/iwlwifi/iwl-io.c
drivers/net/wireless/iwlwifi/iwl-io.h

index 27c66e477833f7747d621fabe489b5d687a3120d..3c263a15df8971d3004c7e4359ba2f29dd4c0367 100644 (file)
 #include "iwl-prph.h"
 #include "iwl-fh.h"
 
+void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val)
+{
+       trace_iwlwifi_dev_iowrite8(trans->dev, ofs, val);
+       iwl_trans_write8(trans, ofs, val);
+}
+IWL_EXPORT_SYMBOL(iwl_write8);
+
+void iwl_write32(struct iwl_trans *trans, u32 ofs, u32 val)
+{
+       trace_iwlwifi_dev_iowrite32(trans->dev, ofs, val);
+       iwl_trans_write32(trans, ofs, val);
+}
+IWL_EXPORT_SYMBOL(iwl_write32);
+
+u32 iwl_read32(struct iwl_trans *trans, u32 ofs)
+{
+       u32 val = iwl_trans_read32(trans, ofs);
+       trace_iwlwifi_dev_ioread32(trans->dev, ofs, val);
+       return val;
+}
+IWL_EXPORT_SYMBOL(iwl_read32);
+
 #define IWL_POLL_INTERVAL 10   /* microseconds */
 
 int iwl_poll_bit(struct iwl_trans *trans, u32 addr,
index 705d12c079e8b2ef2492ca82a56aa92d64cfe09b..501d0560c0618de4ed763260ac499230e60ac510 100644 (file)
 #include "iwl-devtrace.h"
 #include "iwl-trans.h"
 
-static inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val)
-{
-       trace_iwlwifi_dev_iowrite8(trans->dev, ofs, val);
-       iwl_trans_write8(trans, ofs, val);
-}
-
-static inline void iwl_write32(struct iwl_trans *trans, u32 ofs, u32 val)
-{
-       trace_iwlwifi_dev_iowrite32(trans->dev, ofs, val);
-       iwl_trans_write32(trans, ofs, val);
-}
-
-static inline u32 iwl_read32(struct iwl_trans *trans, u32 ofs)
-{
-       u32 val = iwl_trans_read32(trans, ofs);
-       trace_iwlwifi_dev_ioread32(trans->dev, ofs, val);
-       return val;
-}
+void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val);
+void iwl_write32(struct iwl_trans *trans, u32 ofs, u32 val);
+u32 iwl_read32(struct iwl_trans *trans, u32 ofs);
 
 static inline void iwl_set_bit(struct iwl_trans *trans, u32 reg, u32 mask)
 {