ASoC: wm8804: Remove unnecessary suspend/resume bias level changes
authorLars-Peter Clausen <lars@metafoo.de>
Tue, 2 Sep 2014 20:20:33 +0000 (22:20 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 3 Sep 2014 18:26:26 +0000 (19:26 +0100)
The ASoC core will only call the suspend/resume callbacks when the device's
DAPM context is idle. Since this driver sets idle_bias_off to true this
means that the device is already in SND_SOC_BIAS_OFF when the suspend
callback is called, so there is no need to manually set this state again.
There is also no need to go to SND_SOC_BIAS_STANDBY in the resume callback
since the core will go right back to SND_SOC_BIAS_OFF.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8804.c

index 0ea01dfcb6e166a2e9e51e2fbb9cec9f4e4edcd1..3addc5fe5cb23883001d3a28662f94cf59e92fa2 100644 (file)
@@ -518,23 +518,6 @@ static int wm8804_set_bias_level(struct snd_soc_codec *codec,
        return 0;
 }
 
-#ifdef CONFIG_PM
-static int wm8804_suspend(struct snd_soc_codec *codec)
-{
-       wm8804_set_bias_level(codec, SND_SOC_BIAS_OFF);
-       return 0;
-}
-
-static int wm8804_resume(struct snd_soc_codec *codec)
-{
-       wm8804_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       return 0;
-}
-#else
-#define wm8804_suspend NULL
-#define wm8804_resume NULL
-#endif
-
 static int wm8804_remove(struct snd_soc_codec *codec)
 {
        struct wm8804_priv *wm8804;
@@ -671,8 +654,6 @@ static struct snd_soc_dai_driver wm8804_dai = {
 static struct snd_soc_codec_driver soc_codec_dev_wm8804 = {
        .probe = wm8804_probe,
        .remove = wm8804_remove,
-       .suspend = wm8804_suspend,
-       .resume = wm8804_resume,
        .set_bias_level = wm8804_set_bias_level,
        .idle_bias_off = true,