[PATCH] s390: wrong return codes in cio_ignore_proc_init()
authorCornelia Huck <cornelia.huck@de.ibm.com>
Tue, 11 Apr 2006 05:53:45 +0000 (22:53 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Tue, 11 Apr 2006 13:18:37 +0000 (06:18 -0700)
cio_ignore_proc_init() returns 1 in case of success and 0 in case of failure.
The caller tests for != 0, so better return 0 in case of success and -ENOENT
in case of failure.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/s390/cio/blacklist.c

index cb8e2e672b68664680dddf99832ec9940d980f66..0960bef7b199ca6c45868f6e746dee1a862550ac 100644 (file)
@@ -414,11 +414,11 @@ cio_ignore_proc_init (void)
        entry = create_proc_entry ("cio_ignore", S_IFREG | S_IRUGO | S_IWUSR,
                                   &proc_root);
        if (!entry)
-               return 0;
+               return -ENOENT;
 
        entry->proc_fops = &cio_ignore_proc_fops;
 
-       return 1;
+       return 0;
 }
 
 __initcall (cio_ignore_proc_init);