UBI: Fastmap: Remove bogus ubi_assert()
authorRichard Weinberger <richard@nod.at>
Tue, 7 Oct 2014 16:51:07 +0000 (18:51 +0200)
committerRichard Weinberger <richard@nod.at>
Thu, 26 Mar 2015 21:45:58 +0000 (22:45 +0100)
It is legal to have PEBs left in the used list.
This can happen if UBI copies a PEB and a powercut happens
between writing a new fastmap and adding this PEB into the EBA table.
In this case the old PEB will be used.

Signed-off-by: Richard Weinberger <richard@nod.at>
drivers/mtd/ubi/fastmap.c

index 600c4f9683e9ea79eebb6dc02229b54e40914c15..9858bfb223147b3396a8f6f2fd227a3068cb0df6 100644 (file)
@@ -814,7 +814,9 @@ static int ubi_attach_fastmap(struct ubi_device *ubi,
        list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &free, u.list)
                list_move_tail(&tmp_aeb->u.list, &ai->free);
 
-       ubi_assert(list_empty(&used));
+       list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &used, u.list)
+               list_move_tail(&tmp_aeb->u.list, &ai->erase);
+
        ubi_assert(list_empty(&eba_orphans));
        ubi_assert(list_empty(&free));