usb-storage: fix up the unusual_realtek device list
authorAlan Stern <stern@rowland.harvard.edu>
Tue, 17 May 2011 18:45:48 +0000 (14:45 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 17 May 2011 18:56:28 +0000 (11:56 -0700)
This patch (as1461) fixes the unusual_devs entries for the Realtek USB
card reader.  They should be ordered by PID, and they should not
override the Subclass and Protocol values provided by the device.
Otherwise a notification about unnecessary entries gets printed in the
kernel log during probing.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Tested-By: Tony Vroon <tony@linx.net>
CC: <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/storage/unusual_realtek.h

index 3236e0328516cd5b72bb1403a30df62c59ad69a6..e41f50c95ed409e7301ff5a8ad79334e16f08f2d 100644 (file)
 #if defined(CONFIG_USB_STORAGE_REALTEK) || \
                defined(CONFIG_USB_STORAGE_REALTEK_MODULE)
 
-UNUSUAL_DEV(0x0bda, 0x0159, 0x0000, 0x9999,
+UNUSUAL_DEV(0x0bda, 0x0138, 0x0000, 0x9999,
                "Realtek",
                "USB Card Reader",
-               USB_SC_SCSI, USB_PR_BULK, init_realtek_cr, 0),
+               USB_SC_DEVICE, USB_PR_DEVICE, init_realtek_cr, 0),
 
 UNUSUAL_DEV(0x0bda, 0x0158, 0x0000, 0x9999,
                "Realtek",
                "USB Card Reader",
-               USB_SC_SCSI, USB_PR_BULK, init_realtek_cr, 0),
+               USB_SC_DEVICE, USB_PR_DEVICE, init_realtek_cr, 0),
 
-UNUSUAL_DEV(0x0bda, 0x0138, 0x0000, 0x9999,
+UNUSUAL_DEV(0x0bda, 0x0159, 0x0000, 0x9999,
                "Realtek",
                "USB Card Reader",
-               USB_SC_SCSI, USB_PR_BULK, init_realtek_cr, 0),
+               USB_SC_DEVICE, USB_PR_DEVICE, init_realtek_cr, 0),
 
 #endif  /* defined(CONFIG_USB_STORAGE_REALTEK) || ... */