staging: comedi: comedi_buf: remove unreachable dev_warn in comedi_buf_munge()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 10 Jan 2013 17:37:27 +0000 (10:37 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jan 2013 00:56:00 +0000 (16:56 -0800)
Due to the 'while(count < num_bytes)' the computed 'block_size' will
always be a value greater than 0.

Remove the unreachable dev_warn and the (block_size < 0) test.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbobbi@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/comedi_buf.c

index 7d516a07474bf5e39deebef7be0051ca4f3135ff..9d11f416398445f5de0a890f397177cf303f1948 100644 (file)
@@ -215,13 +215,6 @@ static unsigned int comedi_buf_munge(struct comedi_async *async,
                        int block_size = num_bytes - count;
                        unsigned int buf_end;
 
-                       if (block_size < 0) {
-                               dev_warn(s->device->class_dev,
-                                       "%s: %s: bug! block_size is negative\n",
-                                       __FILE__, __func__);
-                               break;
-                       }
-
                        buf_end = async->prealloc_bufsz - async->munge_ptr;
                        if (block_size > buf_end)
                                block_size = buf_end;