ceph: drop CAP_LINK_SHARED when sending "link" request to MDS
authorYan, Zheng <zheng.z.yan@intel.com>
Sun, 21 Jul 2013 12:25:25 +0000 (20:25 +0800)
committerSage Weil <sage@inktank.com>
Sat, 10 Aug 2013 00:54:32 +0000 (17:54 -0700)
To handle "link" request, the MDS need to xlock inode's linklock,
which requires revoking any CAP_LINK_SHARED.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Reviewed-by: Sage Weil <sage@inktank.com>
fs/ceph/dir.c

index f02d82b7933e4399abd235a2527403df3364a2fa..0e4da4a9c213504f9f0eb80acce38a9f8b4863bf 100644 (file)
@@ -796,6 +796,8 @@ static int ceph_link(struct dentry *old_dentry, struct inode *dir,
        req->r_locked_dir = dir;
        req->r_dentry_drop = CEPH_CAP_FILE_SHARED;
        req->r_dentry_unless = CEPH_CAP_FILE_EXCL;
+       /* release LINK_SHARED on source inode (mds will lock it) */
+       req->r_old_inode_drop = CEPH_CAP_LINK_SHARED;
        err = ceph_mdsc_do_request(mdsc, dir, req);
        if (err) {
                d_drop(dentry);