drivers/gpio/gpio-tegra.c: use devm_request_and_ioremap
authorJulia Lawall <julia@diku.dk>
Tue, 27 Dec 2011 14:01:26 +0000 (15:01 +0100)
committerGrant Likely <grant.likely@secretlab.ca>
Mon, 2 Jan 2012 08:43:50 +0000 (01:43 -0700)
Reimplement a call to devm_request_mem_region followed by a call to ioremap
or ioremap_nocache by a call to devm_request_and_ioremap.

The semantic patch that makes this transformation is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@nm@
expression myname;
identifier i;
@@

struct platform_driver i = { .driver = { .name = myname } };

@@
expression dev,res,size;
expression nm.myname;
@@

-if (!devm_request_mem_region(dev, res->start, size,
-                              \(res->name\|dev_name(dev)\|myname\))) {
-   ...
-   return ...;
-}
... when != res->start
(
-devm_ioremap(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
|
-devm_ioremap_nocache(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
)
... when any
    when != res->start
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/gpio/gpio-tegra.c

index 61044c889f7fec11ef8f0f6b81c78fafd15c87a3..bdc2937915906fa7a7589b02e258daccb7b024f7 100644 (file)
@@ -361,14 +361,7 @@ static int __devinit tegra_gpio_probe(struct platform_device *pdev)
                return -ENODEV;
        }
 
-       if (!devm_request_mem_region(&pdev->dev, res->start,
-                                    resource_size(res),
-                                    dev_name(&pdev->dev))) {
-               dev_err(&pdev->dev, "Couldn't request MEM resource\n");
-               return -ENODEV;
-       }
-
-       regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));
+       regs = devm_request_and_ioremap(&pdev->dev, res);
        if (!regs) {
                dev_err(&pdev->dev, "Couldn't ioremap regs\n");
                return -ENODEV;