drm/i915: Clarify WaDisable4x2SubspanOptimization situation for VLV
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 22 Jan 2014 19:33:03 +0000 (21:33 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 29 Jan 2014 19:16:08 +0000 (20:16 +0100)
WaDisable4x2SubspanOptimization isn't listed for VLV in the workaround
database, but BSpec says that the relevant bit must be set. Add a
comment to remind people of this.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_pm.c

index 6c435e48f5541e0430bebe63c37031808236e4d5..cb96b0abb244c06a346e2e684cee0babc15f09ad 100644 (file)
@@ -4945,6 +4945,10 @@ static void valleyview_init_clock_gating(struct drm_device *dev)
 
        I915_WRITE(MI_ARB_VLV, MI_ARB_DISPLAY_TRICKLE_FEED_DISABLE);
 
+       /*
+        * BSpec says this must be set, even though
+        * WaDisable4x2SubspanOptimization isn't listed for VLV.
+        */
        I915_WRITE(CACHE_MODE_1,
                   _MASKED_BIT_ENABLE(PIXEL_SUBSPAN_COLLECT_OPT_DISABLE));