Input: pmic8xxx-pwrkey - pass input device directly to interrupt
authorStephen Boyd <sboyd@codeaurora.org>
Sun, 15 Dec 2013 11:14:47 +0000 (03:14 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sun, 15 Dec 2013 11:58:56 +0000 (03:58 -0800)
Instead of passing the pointer to the container structure just
pass the input device here. This saves a dereference in the fast
path.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/pmic8xxx-pwrkey.c

index b49b738aa9c69c5eb62207bc69b518b4fbe18af0..d618c58f8a2215e00c185e76fb0a069df3238b35 100644 (file)
@@ -36,22 +36,22 @@ struct pmic8xxx_pwrkey {
        int key_press_irq;
 };
 
-static irqreturn_t pwrkey_press_irq(int irq, void *_pwrkey)
+static irqreturn_t pwrkey_press_irq(int irq, void *_pwr)
 {
-       struct pmic8xxx_pwrkey *pwrkey = _pwrkey;
+       struct input_dev *pwr = _pwr;
 
-       input_report_key(pwrkey->pwr, KEY_POWER, 1);
-       input_sync(pwrkey->pwr);
+       input_report_key(pwr, KEY_POWER, 1);
+       input_sync(pwr);
 
        return IRQ_HANDLED;
 }
 
-static irqreturn_t pwrkey_release_irq(int irq, void *_pwrkey)
+static irqreturn_t pwrkey_release_irq(int irq, void *_pwr)
 {
-       struct pmic8xxx_pwrkey *pwrkey = _pwrkey;
+       struct input_dev *pwr = _pwr;
 
-       input_report_key(pwrkey->pwr, KEY_POWER, 0);
-       input_sync(pwrkey->pwr);
+       input_report_key(pwr, KEY_POWER, 0);
+       input_sync(pwr);
 
        return IRQ_HANDLED;
 }
@@ -154,7 +154,7 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, pwrkey);
 
        err = request_irq(key_press_irq, pwrkey_press_irq,
-               IRQF_TRIGGER_RISING, "pmic8xxx_pwrkey_press", pwrkey);
+               IRQF_TRIGGER_RISING, "pmic8xxx_pwrkey_press", pwr);
        if (err < 0) {
                dev_dbg(&pdev->dev, "Can't get %d IRQ for pwrkey: %d\n",
                                 key_press_irq, err);
@@ -162,7 +162,7 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev)
        }
 
        err = request_irq(key_release_irq, pwrkey_release_irq,
-                IRQF_TRIGGER_RISING, "pmic8xxx_pwrkey_release", pwrkey);
+                IRQF_TRIGGER_RISING, "pmic8xxx_pwrkey_release", pwr);
        if (err < 0) {
                dev_dbg(&pdev->dev, "Can't get %d IRQ for pwrkey: %d\n",
                                 key_release_irq, err);
@@ -194,8 +194,8 @@ static int pmic8xxx_pwrkey_remove(struct platform_device *pdev)
 
        device_init_wakeup(&pdev->dev, 0);
 
-       free_irq(key_press_irq, pwrkey);
-       free_irq(key_release_irq, pwrkey);
+       free_irq(key_press_irq, pwrkey->pwr);
+       free_irq(key_release_irq, pwrkey->pwr);
        input_unregister_device(pwrkey->pwr);
        kfree(pwrkey);