Staging: ipack: delete the call to remove() in ipack_driver_register
authorSamuel Iglesias Gonsalvez <siglesias@igalia.com>
Fri, 25 May 2012 08:03:02 +0000 (10:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Jun 2012 05:20:29 +0000 (14:20 +0900)
When a bus driver calls ipack_driver_register(), it should manages the returning
NULL value to undo all the operations it did before this call, and print the
corresponding trace.

It is not a task for the ipack driver to call the remove() function here.

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ipack/ipack.c

index e97be9960098aecb1ae5a3310c3185c9e3ac9f4f..a1448e68fd7a43088c26eba1534270b094413686 100644 (file)
@@ -141,8 +141,6 @@ struct ipack_device *ipack_device_register(struct ipack_bus_device *bus,
 
        ret = device_register(&dev->dev);
        if (ret < 0) {
-               pr_err("error registering the device.\n");
-               dev->driver->ops->remove(dev);
                kfree(dev);
                return NULL;
        }