openvswitch: Reset key metadata for packet execution.
authorPravin B Shelar <pshelar@nicira.com>
Tue, 10 Feb 2015 21:35:16 +0000 (13:35 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Feb 2015 22:40:15 +0000 (14:40 -0800)
Userspace packet execute command pass down flow key for given
packet. But userspace can skip some parameter with zero value.
Therefore kernel needs to initialize key metadata to zero.

Fixes: 0714812134 ("openvswitch: Eliminate memset() from flow_extract.")
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/flow.c

index e2c348b8bacafac9c646f4861b55b76d4e1a51e9..50ec42f170a06713e086d66abb2ea0d1aa998d74 100644 (file)
@@ -717,6 +717,8 @@ int ovs_flow_key_extract_userspace(const struct nlattr *attr,
 {
        int err;
 
+       memset(key, 0, OVS_SW_FLOW_KEY_METADATA_SIZE);
+
        /* Extract metadata from netlink attributes. */
        err = ovs_nla_get_flow_metadata(attr, key, log);
        if (err)