staging/lustre: fix return value check in libcfs_sock_ioctl()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Mon, 3 Jun 2013 02:08:13 +0000 (10:08 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Jun 2013 19:10:47 +0000 (12:10 -0700)
In case of error, the function sock_alloc_file() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/libcfs/linux/linux-tcpip.c

index 6f1f047d65555116d6e4c47d95133976f9811fc9..855c7e87d96f2bd7d7e25735326d3f4c18de0ff6 100644 (file)
@@ -59,9 +59,9 @@ libcfs_sock_ioctl(int cmd, unsigned long arg)
        }
 
        sock_filp = sock_alloc_file(sock, 0, NULL);
-       if (!sock_filp) {
+       if (IS_ERR(sock_filp)) {
                sock_release(sock);
-               rc = -ENOMEM;
+               rc = PTR_ERR(sock_filp);
                goto out;
        }