Drop support for GCC < 4.8 in folly/FBString.h
authorYedidya Feldblum <yfeldblum@fb.com>
Tue, 15 Sep 2015 05:48:41 +0000 (22:48 -0700)
committerfacebook-github-bot-4 <folly-bot@fb.com>
Tue, 15 Sep 2015 06:20:18 +0000 (23:20 -0700)
Summary: [Folly] Drop support for GCC < 4.8 in `folly/FBString.h`.

Can't stay indefinitely backcompat with older compilers.

Reviewed By: @JoelMarcey

Differential Revision: D2441747

folly/FBString.h

index 85a0a6928449218e9370b5011c1bc72bab879ef4..ae1a020b06d3f605d892bc35b3277440ba87f9e4 100644 (file)
@@ -255,15 +255,6 @@ private:
 };
 */
 
-/**
- * gcc-4.7 throws what appears to be some false positive uninitialized
- * warnings for the members of the MediumLarge struct.  So, mute them here.
- */
-#if defined(__GNUC__) && !defined(__clang__)
-# pragma GCC diagnostic push
-# pragma GCC diagnostic ignored "-Wuninitialized"
-#endif
-
 /**
  * This is the core of the string. The code should work on 32- and
  * 64-bit and both big- and little-endianan architectures with any
@@ -899,10 +890,6 @@ private:
   }
 };
 
-#if defined(__GNUC__) && !defined(__clang__)
-# pragma GCC diagnostic pop
-#endif
-
 #ifndef _LIBSTDCXX_FBSTRING
 /**
  * Dummy fbstring core that uses an actual std::string. This doesn't