phy: rockchip-inno-usb2: support tuning phy for rk3399

This patch adds a method to tuning phy with the following
parameters to improve usb driver strength and increase usb2
compatibility.

1. Set max ODT compensation voltage and current tuning reference.
2. Set max pre-emphasis level.
3. Disable the pre-emphasize in eop state and chirp state
   to avoid mis-trigger the disconnect detection and also
   avoid hs handshake fail.

We don't enable the phy tuning by default. If you want to
tuning phy, you can add a property "rockchip,u2phy-tuning"
in u2phy node, like this:

&u2phy0 {
	rockchip,u2phy-tuning;
};

&u2phy1 {
	rockchip,u2phy-tuning;
};

Change-Id: Iaa70e2ad3d5d06662be6c05e4d20784e5bb85ae9
Signed-off-by: William Wu <wulf@rock-chips.com>

diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
index 39939d2511d308dda0f942f8bde6099507d7b5f3..f92b2f1cf9d76ab93fae022defeb8d03ad4c07f2 100644 (file)
--- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
+++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
@@ -11,6 +11,7 @@ Required properties (phy (parent) node):
 Optional properties:
  - clocks : phandle + phy specifier pair, for the input clock of phy.
  - clock-names : input clock name of phy, must be "phyclk".
+ - rockchip,u2phy-tuning; when set, tuning u2phy to improve usb2 SI.
 
 Required nodes : a sub-node is required for each port the phy provides.
                 The sub-node name is used to identify host or otg port,

diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c
index 27199c3a34b1fdef5197449685364847e9548749..8fb4c9169845dc5c76fd8d17cb7183c5ac7aa505 100644 (file)
--- a/drivers/phy/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/phy-rockchip-inno-usb2.c
@@ -1344,6 +1344,63 @@ static int rk3366_usb2phy_tuning(struct rockchip_usb2phy *rphy)
        return ret;
 }
 
+static int rk3399_usb2phy_tuning(struct rockchip_usb2phy *rphy)
+{
+       struct device_node *node = rphy->dev->of_node;
+       int ret = 0;
+
+       if (!of_property_read_bool(node, "rockchip,u2phy-tuning"))
+               return ret;
+
+       if (rphy->phy_cfg->reg == 0xe450) {
+               /*
+                * Set max ODT compensation voltage and
+                * current tuning reference for PHY0.
+                */
+               ret |= regmap_write(rphy->grf, 0x448c,
+                                   GENMASK(23, 16) | 0xe3);
+
+               /* Set max pre-emphasis level for PHY0 */
+               ret |= regmap_write(rphy->grf, 0x44b0,
+                                   GENMASK(18, 16) | 0x07);
+
+               /*
+                * Disable the pre-emphasize in eop state
+                * and chirp state to avoid mis-trigger the
+                * disconnect detection and also avoid hs
+                * handshake fail for PHY0.
+                */
+               ret |= regmap_write(rphy->grf, 0x4480,
+                                   GENMASK(17, 16) | 0x0);
+               ret |= regmap_write(rphy->grf, 0x44b4,
+                                   GENMASK(17, 16) | 0x0);
+       } else {
+               /*
+                * Set max ODT compensation voltage and
+                * current tuning reference for PHY1.
+                */
+               ret |= regmap_write(rphy->grf, 0x450c,
+                                   GENMASK(23, 16) | 0xe3);
+
+               /* Set max pre-emphasis level for PHY1 */
+               ret |= regmap_write(rphy->grf, 0x4530,
+                                   GENMASK(18, 16) | 0x07);
+
+               /*
+                * Disable the pre-emphasize in eop state
+                * and chirp state to avoid mis-trigger the
+                * disconnect detection and also avoid hs
+                * handshake fail for PHY1.
+                */
+               ret |= regmap_write(rphy->grf, 0x4500,
+                                   GENMASK(17, 16) | 0x0);
+               ret |= regmap_write(rphy->grf, 0x4534,
+                                   GENMASK(17, 16) | 0x0);
+       }
+
+       return ret;
+}
+
 #ifdef CONFIG_PM_SLEEP
 static int rockchip_usb2phy_pm_suspend(struct device *dev)
 {
@@ -1403,6 +1460,7 @@ static const struct rockchip_usb2phy_cfg rk3399_phy_cfgs[] = {
        {
                .reg            = 0xe450,
                .num_ports      = 2,
+               .phy_tuning     = rk3399_usb2phy_tuning,
                .clkout_ctl     = { 0xe450, 4, 4, 1, 0 },
                .port_cfgs      = {
                        [USB2PHY_PORT_OTG] = {
@@ -1449,6 +1507,7 @@ static const struct rockchip_usb2phy_cfg rk3399_phy_cfgs[] = {
        {
                .reg            = 0xe460,
                .num_ports      = 2,
+               .phy_tuning     = rk3399_usb2phy_tuning,
                .clkout_ctl     = { 0xe460, 4, 4, 1, 0 },
                .port_cfgs      = {
                        [USB2PHY_PORT_OTG] = {