sbp-target: fix return value check in sbp_register_configfs()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Fri, 21 Sep 2012 05:57:31 +0000 (13:57 +0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sat, 22 Sep 2012 23:29:52 +0000 (16:29 -0700)
In case of error, the function target_fabric_configfs_init() returns
ERR_PTR() not NULL pointer. The NULL test in the return value check
should be replaced with IS_ERR().

dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/sbp/sbp_target.c

index 0ce44cd3488e43e397896a7ffe8da30e306301db..0d6d7c1f025ea11a465fff1a04c8568055214272 100644 (file)
@@ -2543,9 +2543,9 @@ static int sbp_register_configfs(void)
        int ret;
 
        fabric = target_fabric_configfs_init(THIS_MODULE, "sbp");
-       if (!fabric) {
+       if (IS_ERR(fabric)) {
                pr_err("target_fabric_configfs_init() failed\n");
-               return -ENOMEM;
+               return PTR_ERR(fabric);
        }
 
        fabric->tf_ops = sbp_ops;