Fix for ExceptionWrapperTest
authorPhil Willoughby <philwill@fb.com>
Tue, 18 Oct 2016 22:42:55 +0000 (15:42 -0700)
committerFacebook Github Bot <facebook-github-bot-bot@fb.com>
Tue, 18 Oct 2016 22:53:46 +0000 (15:53 -0700)
Summary:
Some platforms do not output anything when `std::terminate` is called; this
fixes the test on those platforms.

Reviewed By: yfeldblum, jsedgwick

Differential Revision: D4001052

fbshipit-source-id: 671fbca9d6d22e372189b6554440c268c0cff60b

folly/test/ExceptionWrapperTest.cpp

index e5e40d0553190cbdb760fc17ebeac085a4f96b55..ebbfcd1669fdeefd865e3733d42c643d7d496cd1 100644 (file)
@@ -229,13 +229,9 @@ TEST(ExceptionWrapper, getExceptionPtr_test) {
   EXPECT_THROW(std::rethrow_exception(eptr), IntException);
 
   // Test with empty ew.
-
-  // Disabling pending fix for fbandroid: t13822116
-  /*
   exception_wrapper empty_ew;
   eptr = empty_ew.getExceptionPtr();
-  EXPECT_DEATH(std::rethrow_exception(eptr), "exception");
-  */
+  EXPECT_FALSE(eptr);
 }
 
 TEST(ExceptionWrapper, with_exception_deduction) {