net/irda: sh_sir: fixup err return value on sh_sir_open
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Mon, 5 Apr 2010 18:43:09 +0000 (18:43 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 Apr 2010 02:50:20 +0000 (19:50 -0700)
On sh_sir_open function, there was a possibility that
err variable didn't have value even though it is return value.
This patch modify it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/irda/sh_sir.c

index d7c983dc91adff1436c7b3ac24d5aa9d6bf8d8c1..761ed012f0bb5d239323babc49806430c1a2fae8 100644 (file)
@@ -645,8 +645,10 @@ static int sh_sir_open(struct net_device *ndev)
        sh_sir_set_baudrate(self, 9600);
 
        self->irlap = irlap_open(ndev, &self->qos, DRIVER_NAME);
-       if (!self->irlap)
+       if (!self->irlap) {
+               err = -ENODEV;
                goto open_err;
+       }
 
        /*
         * Now enable the interrupt then start the queue