staging: Additional item for rtl8188eu TODO list
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Wed, 12 Feb 2014 19:54:32 +0000 (11:54 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Feb 2014 17:19:53 +0000 (09:19 -0800)
The rtw_recv_indicatepkt() function in the file named
drivers/staging/rtl8188eu/os_dep/recv_linux.c has this strange code:

rcu_read_lock();
rcu_dereference(padapter->pnetdev->rx_handler_data);
rcu_read_unlock();

This code has no effect.  Normally, you would assign the result of
rcu_dereference() to some variable, but it is not clear from the
code what variable that would be.  Therefore, this patch applies to
the TODO file instead of the code itself.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/TODO

index f7f389c40e71429d6ee48fd8742dcb7193afab7a..b574b235b3403c6428686d8ff8d01bf31325ec9a 100644 (file)
@@ -9,6 +9,11 @@ TODO:
 - merge Realtek's bugfixes and new features into the driver
 - switch to use LIB80211
 - switch to use MAC80211
+- figure out what to do with this code in rtw_recv_indicatepkt():
+       rcu_read_lock();
+       rcu_dereference(padapter->pnetdev->rx_handler_data);
+       rcu_read_unlock();
+  Perhaps delete it, perhaps assign to some local variable.
 
 Please send any patches to Greg Kroah-Hartman <gregkh@linux.com>,
 and Larry Finger <Larry.Finger@lwfinger.net>.