[WATCHDOG] i6300esb.c-2-bugs-little-cleanup.patch
authorJiri Slaby <xslaby@fi.muni.cz>
Mon, 22 Aug 2005 07:05:03 +0000 (09:05 +0200)
committerWim Van Sebroeck <wim@iguana.be>
Sun, 11 Sep 2005 19:56:10 +0000 (21:56 +0200)
In i6300esb.c watchdog card driver were 2 bugs (misused pc_match_device and
pci_dev_put wasn't called in one error case) and one little cleanup was
done (long line was converted to a shorter one with using built-in macro).

Signed-off-by: Jiri Slaby <xslaby@fi.muni.cz>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Andrew Morton <akpm@osdl.org>
drivers/char/watchdog/i6300esb.c

index 823924e4249bcaaad90929465b0a2abdc9f692a4..575d6cd9e59a41956bce630c851b80c29cdf3b43 100644 (file)
@@ -345,7 +345,7 @@ static struct notifier_block esb_notifier = {
  * want to register another driver on the same PCI id.
  */
 static struct pci_device_id esb_pci_tbl[] = {
-        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB_9, PCI_ANY_ID, PCI_ANY_ID, },
+        { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB_9), },
         { 0, },                 /* End of list */
 };
 MODULE_DEVICE_TABLE (pci, esb_pci_tbl);
@@ -365,7 +365,7 @@ static unsigned char __init esb_getdevice (void)
          */
 
         for_each_pci_dev(dev) {
-                if (pci_match_device(esb_pci_tbl, dev)) {
+                if (pci_match_id(esb_pci_tbl, dev)) {
                         esb_pci = dev;
                         break;
                 }