i2c: imx: fix imx driver to work though signal is pending
authorOskar Schirmer <oskar@scara.com>
Thu, 23 Feb 2012 12:19:11 +0000 (12:19 +0000)
committerWolfram Sang <w.sang@pengutronix.de>
Wed, 29 Feb 2012 19:21:24 +0000 (20:21 +0100)
Interrupt a test application for I2C based mc13xxx driven
touch panel, SIGINT, causes open event file descriptor to be
closed, which in turn causes I2C activity to mask PMIC local
interrupts. This eventually ends up in i2c_imx_bus_busy to
wait for some busy flag to toggle, but while waiting it would
find a signal pending and break. The final symptom is the
device is not closed down cleanly and thus not reopenable.

Do without check for pending signal.

Signed-off-by: Oskar Schirmer <oskar@scara.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
drivers/i2c/busses/i2c-imx.c

index 58832e578fff24dbbff08b38eb82e093a2cf36df..124d9c594f40bc0052b8d0e1cc4861d0024fdfa0 100644 (file)
@@ -149,11 +149,6 @@ static int i2c_imx_bus_busy(struct imx_i2c_struct *i2c_imx, int for_busy)
                        break;
                if (!for_busy && !(temp & I2SR_IBB))
                        break;
-               if (signal_pending(current)) {
-                       dev_dbg(&i2c_imx->adapter.dev,
-                               "<%s> I2C Interrupted\n", __func__);
-                       return -EINTR;
-               }
                if (time_after(jiffies, orig_jiffies + msecs_to_jiffies(500))) {
                        dev_dbg(&i2c_imx->adapter.dev,
                                "<%s> I2C bus is busy\n", __func__);