[SCSI] megaraid_sas: remove sysfs poll_mode_io world writeable permissions
authorBryn M. Reeves <bmr@redhat.com>
Thu, 12 Nov 2009 18:31:54 +0000 (18:31 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 13 Jan 2010 05:12:36 +0000 (21:12 -0800)
/sys/bus/pci/drivers/megaraid_sas/poll_mode_io defaults to being
world-writable, which seems bad (letting any user affect kernel driver
behavior).

This turns off group and user write permissions, so that on typical
production systems only root can write to it.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/megaraid/megaraid_sas.c

index 99ff99e45beeac31167428ddedca6405a5aedef4..708ea3157b60295cd0ae806404ab4dd4e9bd3640 100644 (file)
@@ -4046,7 +4046,7 @@ megasas_aen_polling(struct work_struct *work)
 }
 
 
-static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUGO,
+static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUSR,
                megasas_sysfs_show_poll_mode_io,
                megasas_sysfs_set_poll_mode_io);