rndis_wlan: use kzalloc to allocate private data
authorJussi Kivilinna <jussi.kivilinna@mbnet.fi>
Thu, 12 Jun 2008 17:19:01 +0000 (20:19 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Sat, 14 Jun 2008 16:18:10 +0000 (12:18 -0400)
rndis_wlan used kmalloc to allocate private data structure and leaving data
uninitialized, but later assumed to be set zero.

Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rndis_wlan.c

index 8505d8bcb69d5c5a6a901dbba3a2914c6af82d47..6eb487dcc42fad10b1a897c417c555b3904616c4 100644 (file)
@@ -2522,7 +2522,7 @@ static int rndis_wext_bind(struct usbnet *usbdev, struct usb_interface *intf)
        __le32 tmp;
 
        /* allocate rndis private data */
-       priv = kmalloc(sizeof(struct rndis_wext_private), GFP_KERNEL);
+       priv = kzalloc(sizeof(struct rndis_wext_private), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
@@ -2530,8 +2530,6 @@ static int rndis_wext_bind(struct usbnet *usbdev, struct usb_interface *intf)
         * Otherwise we'll be in big trouble in rndis_wext_early_init().
         */
        usbdev->driver_priv = priv;
-       memset(priv, 0, sizeof(*priv));
-       memset(priv->name, 0, sizeof(priv->name));
        strcpy(priv->name, "IEEE802.11");
        usbdev->net->wireless_handlers = &rndis_iw_handlers;
        priv->usbdev = usbdev;