[media] drivers/media/pci/ttpci/budget-av.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Thu, 6 Sep 2012 14:23:53 +0000 (11:23 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 22 Nov 2012 15:41:31 +0000 (13:41 -0200)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/pci/ttpci/budget-av.c

index 12ddb53c58dcedf00f5229e229f484238dec363e..1f8b1bb0bf9fb39b9881d9bec07e9c604d913e9f 100644 (file)
@@ -1477,8 +1477,8 @@ static int budget_av_attach(struct saa7146_dev *dev, struct saa7146_pci_extensio
 
        if (saa7113_init(budget_av) == 0) {
                budget_av->has_saa7113 = 1;
-
-               if (0 != saa7146_vv_init(dev, &vv_data)) {
+               err = saa7146_vv_init(dev, &vv_data);
+               if (err != 0) {
                        /* fixme: proper cleanup here */
                        ERR("cannot init vv subsystem\n");
                        return err;