Fix a copy+paste bug that Duncan spotted. For several
authorDan Gohman <gohman@apple.com>
Thu, 11 Sep 2008 18:53:02 +0000 (18:53 +0000)
committerDan Gohman <gohman@apple.com>
Thu, 11 Sep 2008 18:53:02 +0000 (18:53 +0000)
cases it was still getting lucky and detecting overflow
but it was clearly incorrect.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@56113 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Scalar/InstructionCombining.cpp

index 46ac762b0a78349d3e9e6d71e91e5a3d4fabf655..5a9d1de2e35bdbb8c2e5e1cf306632d9409fe8a1 100644 (file)
@@ -4699,7 +4699,7 @@ static bool AddWithOverflow(ConstantInt *&Result, ConstantInt *In1,
 /// overflowed for this type.
 static bool SubWithOverflow(ConstantInt *&Result, ConstantInt *In1,
                             ConstantInt *In2, bool IsSigned = false) {
-  Result = cast<ConstantInt>(Add(In1, In2));
+  Result = cast<ConstantInt>(Subtract(In1, In2));
 
   if (IsSigned)
     if (In2->getValue().isNegative())