crypto: omap-aes - Convert request_irq to devm_request_irq
authorJoel Fernandes <joelf@ti.com>
Sun, 18 Aug 2013 02:42:34 +0000 (21:42 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 21 Aug 2013 11:28:05 +0000 (21:28 +1000)
Keeps request_irq exit/error code paths simpler.

Suggested-by: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: Joel Fernandes <joelf@ti.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/omap-aes.c

index 1f3d816cc9e6543a8ff8901a656d64683ab91ee6..ce791c2f81f79e4ffda5d7d44e6a31a8a46bcb34 100644 (file)
@@ -1207,7 +1207,7 @@ static int omap_aes_probe(struct platform_device *pdev)
                        goto err_irq;
                }
 
-               err = request_irq(irq, omap_aes_irq, 0,
+               err = devm_request_irq(dev, irq, omap_aes_irq, 0,
                                dev_name(dev), dd);
                if (err) {
                        dev_err(dev, "Unable to grab omap-aes IRQ\n");
@@ -1242,9 +1242,7 @@ err_algs:
                for (j = dd->pdata->algs_info[i].registered - 1; j >= 0; j--)
                        crypto_unregister_alg(
                                        &dd->pdata->algs_info[i].algs_list[j]);
-       if (dd->pio_only)
-               free_irq(irq, dd);
-       else
+       if (!dd->pio_only)
                omap_aes_dma_cleanup(dd);
 err_irq:
        tasklet_kill(&dd->done_task);