Codegen (Reg|imm)+&GV as an LEA, because we cannot put it into the immediate field

of an ADDri (due to current restrictions on MachineOperand :( ).  This allows
us to generate:

        leal Data+16000, %edx

instead of:

        movl $Data, %edx
        addl $16000, %edx

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@19420 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Target/X86/X86ISelPattern.cpp b/lib/Target/X86/X86ISelPattern.cpp
index 13839ffb9a23678ee7be710a65012e4dc02da94a..265e38815bb291a6938c0deb4d4eac0ca3ddad87 100644 (file)
--- a/lib/Target/X86/X86ISelPattern.cpp
+++ b/lib/Target/X86/X86ISelPattern.cpp
@@ -1027,11 +1027,11 @@ unsigned ISel::SelectExpr(SDOperand N) {
       if (!SelectAddress(N.getOperand(0), AM) &&
           !SelectAddress(N.getOperand(1), AM)) {
        // If this is not just an add, emit the LEA.  For a simple add (like
-       // reg+reg or reg+imm), we just emit an add.  If might be a good idea to
+       // reg+reg or reg+imm), we just emit an add.  It might be a good idea to
        // leave this as LEA, then peephole it to 'ADD' after two address elim
        // happens.
         if (AM.Scale != 1 || AM.BaseType == X86AddressMode::FrameIndexBase ||
-            AM.Base.Reg && AM.IndexReg && (AM.Disp || AM.GV)) {
+            AM.GV || (AM.Base.Reg && AM.IndexReg && AM.Disp)) {
           addFullAddress(BuildMI(BB, X86::LEA32r, 4, Result), AM);
           return Result;
         }