OMAPDSS: DPI displays: Take care of panel timings in the driver itself
authorArchit Taneja <archit@ti.com>
Wed, 8 Aug 2012 08:59:48 +0000 (14:29 +0530)
committerArchit Taneja <archit@ti.com>
Mon, 13 Aug 2012 10:14:39 +0000 (15:44 +0530)
The timings maintained in omap_dss_device(dssdev->panel.timings) should be
maintained by the panel driver itself. It's the panel drivers responsibility
to update it if a new set of timings is to be configured. The DPI interface
driver shouldn't be responsible of updating the panel timings, it's responsible
of maintianing it's own copy of timings.

Signed-off-by: Archit Taneja <archit@ti.com>
drivers/video/omap2/displays/panel-generic-dpi.c
drivers/video/omap2/displays/panel-tfp410.c
drivers/video/omap2/displays/panel-tpo-td043mtea1.c
drivers/video/omap2/dss/dpi.c

index 8d4e102bb0e616692e9b48b36982fdc90e2de26f..a07e18c8f71b97c0ba96dfd535ec648f576d2c22 100644 (file)
@@ -730,6 +730,8 @@ static void generic_dpi_panel_set_timings(struct omap_dss_device *dssdev,
 
        omapdss_dpi_set_timings(dssdev, timings);
 
+       dssdev->panel.timings = *timings;
+
        mutex_unlock(&drv_data->lock);
 }
 
index c6f950321f210c23c73dba250e0e59c5b5df3de2..9397236084b17c49a57d5d6c1212d946bb5e0537 100644 (file)
@@ -234,6 +234,7 @@ static void tfp410_set_timings(struct omap_dss_device *dssdev,
 
        mutex_lock(&ddata->lock);
        omapdss_dpi_set_timings(dssdev, timings);
+       dssdev->panel.timings = *timings;
        mutex_unlock(&ddata->lock);
 }
 
index ecb163e4cfafe1fed5ecf8e8ce9faed5a1ae094c..3f47f5f594b42bf5b75a975b1584a3acc9a65352 100644 (file)
@@ -483,6 +483,8 @@ static void tpo_td043_set_timings(struct omap_dss_device *dssdev,
                struct omap_video_timings *timings)
 {
        omapdss_dpi_set_timings(dssdev, timings);
+
+       dssdev->panel.timings = *timings;
 }
 
 static int tpo_td043_check_timings(struct omap_dss_device *dssdev,
index 97c7a10bc9ff70e6688b307b050a7bd2ed2a7f33..d561a9198a8d12b9e096de6a18ecc09fb872f656 100644 (file)
@@ -283,7 +283,6 @@ void omapdss_dpi_set_timings(struct omap_dss_device *dssdev,
        mutex_lock(&dpi.lock);
 
        dpi.timings = *timings;
-       dssdev->panel.timings = *timings;
 
        if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE) {
                r = dispc_runtime_get();