cpufreq: interactive: don't handle transition notification if not enabled
authorTodd Poynor <toddpoynor@google.com>
Sun, 23 Dec 2012 20:28:49 +0000 (12:28 -0800)
committerArve Hjønnevåg <arve@android.com>
Mon, 1 Jul 2013 21:16:19 +0000 (14:16 -0700)
If multiple governors are in use then avoid processing frequency transition
notifications for CPUs on which the interactive governor is not enabled.

Change-Id: Ibd75255b921d887501a64774a8c4f62302f2d4e4
Reported-by: Francisco Franco <francisco.franco@cloudcar.com>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
drivers/cpufreq/cpufreq_interactive.c

index c8358a3b5454837f7f515132a6a0c6db7e0e4076..51c34bf9c17316249b819528bdcb22b44b48a120 100644 (file)
@@ -552,6 +552,12 @@ static int cpufreq_interactive_notifier(
 
        if (val == CPUFREQ_POSTCHANGE) {
                pcpu = &per_cpu(cpuinfo, freq->cpu);
+               if (!down_read_trylock(&pcpu->enable_sem))
+                       return 0;
+               if (!pcpu->governor_enabled) {
+                       up_read(&pcpu->enable_sem);
+                       return 0;
+               }
 
                for_each_cpu(cpu, pcpu->policy->cpus) {
                        struct cpufreq_interactive_cpuinfo *pjcpu =
@@ -560,8 +566,9 @@ static int cpufreq_interactive_notifier(
                        update_load(cpu);
                        spin_unlock(&pjcpu->load_lock);
                }
-       }
 
+               up_read(&pcpu->enable_sem);
+       }
        return 0;
 }