Remove superfluous std::move calls

Summary: clang-3.7 upstream warns that these calls prevent a copy elision
(-Wpessimizing-move).

Reviewed By: @​mzlee

Differential Revision: D2366951

diff --git a/folly/IPAddress.h b/folly/IPAddress.h
index 797ab57c744c3b92d2edbc4b44655eb9fc54c054..cf83e2dbac5e0cc229dc1f705be734e3a608865a 100644 (file)
--- a/folly/IPAddress.h
+++ b/folly/IPAddress.h
@@ -363,8 +363,8 @@ class IPAddress : boost::totally_ordered<IPAddress> {
    * @return IPAddress instance with bits set to 0
    */
   IPAddress mask(uint8_t numBits) const {
-    return isV4() ? IPAddress(std::move(asV4().mask(numBits)))
-                  : IPAddress(std::move(asV6().mask(numBits)));
+    return isV4() ? IPAddress(asV4().mask(numBits))
+                  : IPAddress(asV6().mask(numBits));
   }
 
   /**

diff --git a/folly/IPAddressV4.h b/folly/IPAddressV4.h
index 7355648227ba0d6efc8c07ae21a5ccd141abe3da..8b750fff7a25279138294008a2dc46ea83b70507 100644 (file)
--- a/folly/IPAddressV4.h
+++ b/folly/IPAddressV4.h
@@ -180,7 +180,7 @@ class IPAddressV4 : boost::totally_ordered<IPAddressV4> {
   ByteArray4 toByteArray() const {
     ByteArray4 ba{{0}};
     std::memcpy(ba.data(), bytes(), 4);
-    return std::move(ba);
+    return ba;
   }
 
   // @see IPAddress#toFullyQualified