libertas: fix use-before-check violation
authorHolger Schurig <hs4233@mail.mn-solutions.de>
Tue, 29 Apr 2008 08:07:56 +0000 (10:07 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 1 May 2008 00:34:27 +0000 (20:34 -0400)
According to Coverity (kudo's to Adrian Bunk), we had one use-before-check
bug in libe libertas driver. This patch fixes this issue.

Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/libertas/scan.c

index e72c97a0d6c1f36bbed6edbf2d50f38e8f57a1a0..7234669d05c003819458274ec2d48a9ed235820a 100644 (file)
@@ -298,7 +298,8 @@ static int lbs_do_scan(struct lbs_private *priv, uint8_t bsstype,
        uint8_t *tlv;   /* pointer into our current, growing TLV storage area */
 
        lbs_deb_enter_args(LBS_DEB_SCAN, "bsstype %d, chanlist[].chan %d, chan_count %d",
-                          bsstype, chan_list[0].channumber, chan_count);
+               bsstype, chan_list ? chan_list[0].channumber : -1,
+               chan_count);
 
        /* create the fixed part for scan command */
        scan_cmd = kzalloc(MAX_SCAN_CFG_ALLOC, GFP_KERNEL);